Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2169 - new simple input page for "Labels" #2202

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • app_en.arb: added 5 translations
  • app_fr.arb: added 5 translations
  • edit_product_page.dart: added an action for "edit labels"; refactored
  • simple_input_page.dart: renamed "label" as "term" to avoid confusion; translated; refactored
  • simple_input_page_helpers.dart: implementation for "labels"; renamed "label" as "term"; translated
  • smooth_alert_dialog.dart: minor refactoring

What

  • Now we can edit the "Labels" too.

Screenshot

Capture d’écran 2022-06-07 à 12 36 47

Capture d’écran 2022-06-07 à 12 37 07

Capture d’écran 2022-06-07 à 12 37 30

Part of

Impacted files:
* `app_en.arb`: added 5 translations
* `app_fr.arb`: added 5 translations
* `edit_product_page.dart`: added an action for "edit labels"; refactored
* `simple_input_page.dart`: renamed "label" as "term" to avoid confusion; translated; refactored
* `simple_input_page_helpers.dart`: implementation for "labels"; renamed "label" as "term"; translated
* `smooth_alert_dialog.dart`: minor refactoring
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner June 7, 2022 10:38
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teolemon teolemon added ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✏️ Editing - labels labels Jun 7, 2022
@teolemon teolemon merged commit a869b66 into openfoodfacts:develop Jun 7, 2022
@teolemon
Copy link
Member

teolemon commented Jun 7, 2022

thank you @monsieurtanuki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - labels ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants